Repository navigation
fix(buyer): slow or busy winners get time to deliver before they are benched; v0.3.6 - #230
Merged
Merged
Conversation
…benched Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan13 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 8 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
Collaborator
Author
|
Merging with one red check: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Watching the new queue serve jobs live (dev2 gateway on v0.3.2/0.3.3, 12:42 to 13:09Z), queued images never completed. The fastest remaining bidder, AmaKBdpB (bench 1,606, against dev2's ~5,500 reference), needs about 7 min per image, but the gateway gives a winner 6 min (
IMAGE_RECEIPT_TIMEOUT) before "winner never delivered; benched". The job re-queued, and the bench fallback (#212) handed it straight back to the same node, the only bidder, so it looped on wasted renders. The node's bids quote the default 60 s ETA because it has not completed a job since restarting.What
buyer::receipt_wait(base, winner)replaces the fixed receipt timeout. It is the auction's timeout, made longer for a winner that says it needs longer (2.5x its quoted ETA) or that benchmarks slower than the reference score of 5,000 (scaled by how much slower), and never more than 4x the timeout. A reference-speed node keeps the plain timeout; AmaKBdpB gets about 19 min instead of 6. Applies to every buyer, gateway or CLI.Also bumps to v0.3.6 (v0.3.5 is claimed by #225, which is merged, and by open #227/#228).
Tests
cargo test -p c0mpute-core --lib --test auction_e2e --test video_e2e: 468 + 3 + 6 pass.🤖 Generated with Claude Code