Repository navigation
fix(apps): restore state into the volume, not docker cp into a created container; v0.3.3 - #221
Merged
Merged
Conversation
…reated container; v0.3.3 Live on dev2 (Docker 29.9, containerd image store) every failover restore failed: `docker cp - <created container>:/` answers "destination must be a directory" because a container that never started has no filesystem yet. docker cp exited, the stdin write hit a closed pipe, and with SIGPIPE at its default the gateway worker died (systemd counted it a clean exit) on every promotion: a crash loop on the only Moshpit gateway until apps was turned off there. (#219 already keeps SIGPIPE ignored in long-running commands.) Restore now unpacks the snapshot into a fresh state volume with a pinned busybox helper (`docker run --rm -i --network none -v <vol>:/restore ... tar -x --strip-components=1`) before the app container is created; Docker leaves a non-empty named volume alone, so the app starts on that state. Verified against real Docker on dev2. The e2e fake models the new restore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan13 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 8 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This was referenced Nov 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every failover restore failed on Docker 29 (containerd image store):
docker cpinto a never-started container answers "destination must be a directory". With SIGPIPE at its default that killed the dev2 gateway worker on each promotion (a crash loop;appsis turned off on dev2 and dev3 until this ships). #219 already keeps SIGPIPE ignored in long-running commands.Restore now unpacks the snapshot into the state volume with a pinned busybox helper before the app container is created. Verified against real Docker on dev2; the e2e fake models the new restore path.
🤖 Generated with Claude Code