Repository navigation
Skip empty Word text elements without consuming following content - #159
Merged
Merged
Conversation
Each of these PRs passed alone and failed together: - profullstack#149 emits start="N" on ordered lists, so the profullstack#161 marker-width tests that begin at 12345 now expect the attribute. - profullstack#131 resolves every federated host before connecting, so the profullstack#128 directory salary tests pass allowPrivate like the other federation tests do. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A valid empty Word text element such as
<w:t />or<w:t xml:space="preserve"/>is currently interpreted as the opening of a text element. The importer then consumes through the next closing text tag:<w:t /><w:t>Engineer</w:t>imports as<w:t>Engineer. Intervening line breaks and tabs can also turn into literal XML instead of controls.Exclude self-closing openings from the paired-text match. Empty elements contribute no text, while subsequent text and controls are processed independently. This is separate from the existing paragraph/run opening-tag whitespace PR.
Validation: unchanged upstream fails five of the eight new cases and passes three controls. All eight new cases, the existing Word emphasis test, and the existing DOCX inline-control fixture pass after the fix (10 total). Build and TypeScript no-emit checks pass; the new test file passes Prettier. Cases cover spaced and attributed empty elements, line breaks, tabs, carriage returns, emphasis, adjacent runs, and XML entity decoding. Production changes are limited to the text-element matcher and its comment.
Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Settlement remains native SOL on Solana mainnet, subject to acceptance and confirmation of the exact token amount. No reward is claimed as received.