Preserve literal hashes in plain-text summaries - #158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain-text summaries currently replace every
#with a space. As a result,C# and F#becomesC and F,#42loses its reference marker, andhttps://example.com/guide#partbecomes a different string. The sharedtoPlainTextfunction feeds metadata descriptions, feed text, and TUI descriptions.Remove ATX heading markers at line boundaries instead, including optional closing hashes and headings within blockquotes. Preserve hashes that are part of ordinary text. Other inline-markup stripping and truncation behavior remain unchanged.
Validation: the unchanged upstream fails four new regressions and passes two controls. All six new tests and the existing plain-text summary test pass after the fix (7 total). Build, TypeScript no-emit checks, and Prettier checks pass. Cases cover language names, issue references, hashtags, URL fragments, heading syntax, quoted headings, empty headings, and excluded fenced examples.
Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Settlement remains native SOL on Solana mainnet, subject to acceptance and confirmation of the exact token amount. No reward is claimed as received.