Repository navigation
Render C# and F# fenced examples as code - #156
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C# and F# fenced examples are rendered as prose because the renderer's language identifier pattern excludes
#. Ac#example containing# example headingtherefore becomes a document heading, and a following paragraph can end up inside an unintended code block.Allow
#in the existing single-token language identifier. This keeps C#/F# examples literal without changing fence delimiters, closing rules, or the treatment of unsupported multiword info strings.Validation: the unchanged upstream fails three new regressions and passes the existing-language control. After the fix, all four new tests, the parser-progress regression, and four existing fence tests pass (9 total). Build, TypeScript no-emit checks, and Prettier checks pass. Tests cover backticks, tildes within a blockquote, an unterminated fence, and existing C++/Objective-C identifiers.
Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Settlement remains native SOL on Solana mainnet, subject to acceptance and confirmation of the exact token amount. No payment is claimed as received.