Respect plain-text summary length limits - #153
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toPlainTextreserves one character for an ellipsis but appends three periods. A long Chinese summary requested at 160 characters is therefore returned at 162 characters; a zero limit returns almost the entire source. The helper feeds specification summaries, discovery previews, and the terminal job view.Count the suffix within the requested limit, handle short limits, and preserve complete Unicode surrogate pairs when cutting text. Keep existing word-boundary truncation and markup stripping behavior.
Validation: reproduced oversized output and a split emoji before the fix; two focused plain-text tests pass afterward. Independent checks cover 27 input/limit combinations and preservation cases, including long CJK and emoji strings, tiny limits, exact fits, and word boundaries. Build, typecheck, and diff checks pass. The existing UTF-16 string-length budget is preserved.
Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Requested settlement remains native SOL on Solana mainnet; acceptance and the exact net token amount still require the payer's confirmation.