Preserve parentheses in Markdown link destinations - #151
Merged
Merged
Conversation
Each of these PRs passed alone and failed together: - profullstack#149 emits start="N" on ordered lists, so the profullstack#161 marker-width tests that begin at 12345 now expect the attribute. - profullstack#131 resolves every federated host before connecting, so the profullstack#128 directory salary tests pass allowPrivate like the other federation tests do. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit Markdown links truncate destinations containing parentheses. For example,
[Example](https://example.com/reports(2026))points to the incomplete URL and leaves a stray closing parenthesis in the rendered text. Escaped parentheses and image destinations are affected too.Parse balanced and escaped destination parentheses, then consume an optional quoted title separately. Keep the existing URL allowlist, output escaping, bare-URL behavior, image-to-link option and empty-link behavior unchanged. This is a bounded rendering fix, not a claim of complete CommonMark support.
Validation: the ordinary destination regression fails against upstream
282feb1and passes with this change. Five focused offline rendering tests pass, covering links, images, titles (including unmatched parentheses in title text), punctuation, empty labels and existing bare URLs. Production TypeScript build, TypeScript checking andgit diff --checkpass. No external-service tests or unrelated security cases were run.Reference: GFM link destination syntax.
Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Requested settlement remains native SOL on Solana mainnet, with acceptance and the exact net token amount confirmed before payment.