Keep escaped table pipes from dropping later columns - #150
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escaped pipes in a resume or job-description table split one cell into two and can discard the real final column. For example,
Shell A\|Bfollowed by3 yearsrenders asShell A\andB, losing the experience value.Split rows at unescaped pipes and remove one pipe escape at the table-parsing stage. Preserve header text, code spans, optional outside delimiters, empty cells and right alignment. This also keeps a pipe after multiple backslashes inside its cell, matching the GFM table scanner. General inline backslash processing is unchanged.
Validation: the original data-loss fixture fails on upstream
282feb1and passes with the fix. Focused offline table tests, production TypeScript build, test TypeScript checking andgit diff --checkpass. Only ordinary text-rendering cases were run; no external service tests or unrelated security cases were executed.Reference: GFM tables and escaped pipes, cmark-gfm table scanner and table-stage pipe unescaping.
Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Requested settlement remains native SOL on Solana mainnet, with acceptance and the exact net token amount confirmed before payment.