Preserve query and fragment suffixes in profile account URLs - #148
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenProfile drops distinct resume links when a query value or fragment ends in a slash. For example,
?folder=notesand?folder=notes/collapse into one account because the deduplication key strips trailing slashes from the entire URL.Preserve suffixes in URLs with a query or fragment, while retaining scheme/host normalization and the existing bare-path trailing-slash equivalence. Original link labels and displayed URLs are unchanged. URLs whose path slash precedes a query or fragment also retain their existing distinct identities.
Validation: the new suffix regression fails against upstream
282feb1. After the fix, all 11 tests intest/openprofile.test.tspass, including query-only, fragment-only, combined suffixes, path distinctions and existing deduplication controls. Production TypeScript compilation, test type-checking andgit diff --checkpass. Verification used synthetic offline fixtures on Node 25.8.1; no external service tests were run.Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Requested settlement remains native SOL on Solana mainnet, with acceptance and the exact net token amount confirmed before payment.