Keep importing after an incomplete structured job posting - #147
Merged
ralyodio merged 3 commits intoSep 21, 2026
Merged
Conversation
Each of these PRs passed alone and failed together: - profullstack#149 emits start="N" on ordered lists, so the profullstack#161 marker-width tests that begin at 12345 now expect the attribute. - profullstack#131 resolves every federated host before connecting, so the profullstack#128 directory salary tests pass allowPrivate like the other federation tests do. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page contains an incomplete
JobPostingbefore a complete one, the importer selects the first node and falls back to page text. The complete structured title, description, employment type and remote status are consequently lost.Continue through the existing JSON-LD nodes until a usable title and readable description are found. Preserve first-valid precedence, and retain the existing page fallback and warnings when every posting is incomplete. This changes only the selection step in the existing extractor.
Validation: three regression cases fail against upstream
282feb1; after the fix all five dedicated tests pass, and the TypeScript build passes. Synthetic fixtures cover separate JSON-LD blocks, an array with an@graph, an earlier HTML description with no readable text, first-valid precedence, and all-invalid fallback. Tests verify exact selected content, employment/workplace fields and warnings. No live job-site integration is claimed.Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Requested settlement remains native SOL on Solana mainnet, with acceptance and the exact net token amount confirmed before payment.