Keep fenced code examples out of resume field extraction - #143
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code samples in a Markdown resume currently become resume structure: an example
##creates a new section,###creates another entry, and sample bullets can become achievements. A fenced example before the real name can even supply the displayed name. This change keeps fenced code in the current section or entry body and resumes normal field extraction after the closing marker.The parser recognizes backtick and tilde fences, requires a closing marker of the same type and at least the opening length, and retains an unfinished block through the end of the document. Ordinary inline backticks remain ordinary text. The full original Markdown stays unchanged. The marker rules follow CommonMark fenced code blocks; this change is limited to OpenResume field extraction, separate from the rendered Markdown fence fix in #109.
Validation: six regression cases fail on upstream
282feb1; after the fix, the TypeScript build and all 41 tests in the new fence suite and existing resume/contact/date-range suites pass. The seventh new case checks that inline or invalid markers do not hide later sections.Submitted under the published $0.25 USD-equivalent reward per valid bug-fix PR, using the existing application and settlement conversation. Please confirm acceptance and the exact net amount before payment in native SOL on Solana mainnet to
5wzc9saR1iiPSCLoGS7DU6bbEiCUysUUcPhLx2E7KcRU. AI-assisted change.