Preserve DOCX content with multiline XML opening tags - #142
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid WordprocessingML permits a tab, carriage return or newline between an element name and its attributes. The DOCX importer currently recognizes only a space or
>after paragraph, run, list-property and table names. A multiline paragraph can disappear, a tab-separated run loses its text, and multiline list/table tags lose their interpretation.This change accepts the four XML whitespace characters at those existing boundaries. It keeps the parser's current structure and adds a deterministic DOCX fixture alongside its readable
word/document.xml.Validation: four regression cases fail on upstream; the unchanged-spacing control passes. With the fix, the TypeScript build and all seven related DOCX tests pass:
Please review this ordinary document-import fix under the advertised valid bug-fix PR reward. Any accepted reward should use native SOL on Solana mainnet at the existing address
5wzc9saR1iiPSCLoGS7DU6bbEiCUysUUcPhLx2E7KcRU; please confirm the net amount before payment.