Repository navigation
Conversation
- Preserve child properties from JSDoc in convert.mjs and shared-helpers.mjs - Dynamically construct Zod object schemas for options bag descriptors - Add structural scoring penalty (+3) to avoid overload tie-breaking against primitives - Decompose error paths to avoid undefined parameter positions in FES messages - Add unit tests for options object validation in param_errors.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7752
[WIP]
Changes:
When calling p5 func. that take a settings object, FES previously only checked if an object was passed, ignoring any mistakes inside it
trueorfalse), FES now points directly to the setting that needs fixing'seconds'or'frames'), FES warns when an invalid value is used.PR Checklist
npm run lintpasses