Repository navigation
fix(strands): preserve loop state updated before break - #9354
Merged
davepagurek merged 1 commit intoOct 29, 2026
Merged
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: 90c982e Previous deploymentsThis is an automated message. |
davepagurek
approved these changes
Oct 29, 2026
davepagurek
left a comment
davepagurek
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this! I did some testing and logging of the transpiled js + compiled glsl and the behaviour seems correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9327
Loop state was only written back at the end of the loop body, so a
breakcould exit with the value from the start of that iteration.This updates the Strands loop handling so the current carried values are committed before
break.Changes:
breakbefore control-flow renaming, so they resolve to the live value at the break site.StrandsForbefore emitting the break.Tested on both WebGL and WebGPU.