Repository navigation
fix(color): stop re-wrapping p5.Color for every sketch - #9350
Open
Akshats-git wants to merge 4 commits into
Open
Akshats-git wants to merge 4 commits into
Akshats-git wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Akshats-git
force-pushed
the
fix/color-instance-wrappers
branch
from
October 28, 2026 04:35
f2c0810 to
33fa03a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #9299
Changes:
Every new sketch wrapped the
p5.Colormethods again. Removed sketches stayed in memory, andred(),green(),blue()andalpha()could use the ranges of the wrong sketch.red(),green(),blue()andalpha()now pass their ranges, like Include use of relevant maxes inhue(),saturation(),brightness()andlightness()#8062 did forhue().registerDecoratoronce. Each color keeps a link to its sketch. Aremovehook clears that link.setAlpha()now uses the alpha range of the color's mode. This fixes the HSB case from the issue.Added
test/unit/color/instances.js.PR Checklist
npm run lintpassesI used Claude Code to help with this.