fix: resolve oxlint warnings without removing code - #9161
Merged
Conversation
Resolve all oxlint warnings without removing any code. Helpers that are currently unreferenced are kept and suppressed with a note explaining why, matching the existing treatment of #determinant4x4 in Matrix.js.
Continuous ReleaseCDN linkPublished PackagesCommit hash: 4e2a869 Previous deploymentsThis is an automated message. |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands #9103, which was reverted in #9160.
Changes:
Resolves all 143
oxlintwarnings.npm run lintexits clean. No lint config was changed.The difference from #9103: no code is removed. Every function, method or field that was previously deleted is reinstated with an
oxlint-disable-next-lineand a short note saying why it is kept, matching how#determinant4x4inMatrix.jswas already handled. That covers#toColorMode,calculateOffset,destroyClickedElement,getNodeKey,makeGuardedCallbacks,#matrixand thetextFontdestructure.testImageRenderandcreateDummyFileare commented out alongside their commented-out callers rather than deleted.What is still changed rather than suppressed:
catch (e) {}becomescatch {}==becomes===// falls throughon intentional switch fallthroughs{ }aroundcasebodies containing declarationsif (0)blocks and unreachable post-throwcode removedThe duplicate
remove()inRenderer3Dis left exactly as it is on main, with ano-dupe-class-memberssuppression, so this PR changes no runtime behaviour. The actual fix for that is a separate PR since it is a behaviour change.Screenshots of the change:
N/A
PR Checklist
npm run lintpasses