Skip to content

fix: resolve oxlint warnings without removing code - #9161

Merged
ksen0 merged 1 commit into
processing:mainfrom
Vaivaswat2244:fix/lint-warnings-v2
Sep 11, 2026
Merged

fix: resolve oxlint warnings without removing code#9161
ksen0 merged 1 commit into
processing:mainfrom
Vaivaswat2244:fix/lint-warnings-v2

Conversation

@Vaivaswat2244

Copy link
Copy Markdown
Contributor

Re-lands #9103, which was reverted in #9160.

Changes:

Resolves all 143 oxlint warnings. npm run lint exits clean. No lint config was changed.

The difference from #9103: no code is removed. Every function, method or field that was previously deleted is reinstated with an oxlint-disable-next-line and a short note saying why it is kept, matching how #determinant4x4 in Matrix.js was already handled. That covers #toColorMode, calculateOffset, destroyClickedElement, getNodeKey, makeGuardedCallbacks, #matrix and the textFont destructure. testImageRender and createDummyFile are commented out alongside their commented-out callers rather than deleted.

What is still changed rather than suppressed:

  • unused imports removed
  • catch (e) {} becomes catch {}
  • == becomes ===
  • // falls through on intentional switch fallthroughs
  • { } around case bodies containing declarations
  • dead if (0) blocks and unreachable post-throw code removed

The duplicate remove() in Renderer3D is left exactly as it is on main, with a no-dupe-class-members suppression, so this PR changes no runtime behaviour. The actual fix for that is a separate PR since it is a behaviour change.

Screenshots of the change:

N/A

PR Checklist

  • npm run lint passes
  • Inline reference is included / updated (N/A, no public API changes)
  • Unit tests are included / updated (N/A, existing suites pass unchanged: 2174 passed, 0 failed)

Resolve all oxlint warnings without removing any code. Helpers that are
currently unreferenced are kept and suppressed with a note explaining why,
matching the existing treatment of #determinant4x4 in Matrix.js.
@p5-bot

p5-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

Continuous Release

CDN link

Published Packages

Commit hash: 4e2a869

Previous deployments

This is an automated message.

@ksen0

ksen0 commented Sep 11, 2026

Copy link
Copy Markdown
Member

Thank you!

@ksen0
ksen0 merged commit dc97a4f into processing:main Sep 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants