fix: handle network errors in saveProject (#4276) - #4304
Closed
PS01K wants to merge 1 commit into
Closed
Conversation
- Guard against undefined error.response in saveProject catch blocks using optional chaining - Pass response?.data safely to projectSaveFail - Add unit tests covering saveProject network errors and HTTP error responses
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #4276
When saving a project (
PUT /projects/:idfor updates orPOST /projectsfor new sketches) fails due to a network error, request timeout, or server disconnection, Axios creates an error object whereerror.responseisundefined.Previously, both
.catch()handlers insaveProject()directly accessedresponse.status(if (response.status === 403) ...) andresponse.data(dispatch(projectSaveFail(response.data))). Becauseresponseisundefined, this threw an unhandledTypeError: Cannot read properties of undefined (reading 'status'), causing an unhandled promise rejection instead of gracefully executing save failure handling.Changes:
client/modules/IDE/actions/project.js:response?.status === 403andresponse?.status === 409checks in both update (PUT) and creation (POST) catch blocks using optional chaining.response?.datatoprojectSaveFail(response?.data).client/modules/IDE/actions/project.unit.test.js:saveProjectfor existing project update and new project creation under network error conditions (error.responseundefined), verifying thatendSavingProject, toast notification, andprojectSaveFailare dispatched without throwingTypeError.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #4276