chore(deps): bump bpmn-visualization from 0.44.0 to 0.48.0#51
Merged
Conversation
Bump bpmn-visualization to 0.48.0 in bpmn-rendering-miwg-test-suite and adapt the surrounding code and CI. - main.ts: switch from promise chains to async/await for clearer, linear control flow. The fetch and the response.ok check are split so only the fetch is wrapped in try/catch, avoiding a 'throw caught locally' warning while preserving the original error behavior. - Add a build workflow that runs on push to main and on PRs, path-filtered to the subproject. - Pin all third-party GitHub Actions to full commit SHAs (with version comments) to harden the supply chain; bonitasoft/* actions are external here since the repo lives under the process-analytics org.
tbouffard
added
dependencies
npm ci hung for over 20 minutes in the playwright-chromium postinstall, which downloads a full Chromium binary. The build job only runs tsc && vite build, which needs the playwright npm package but not the browser, so skip the download with PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1. The browser is only required by the generate-screenshots script, which this workflow does not run.
Replace PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD with npm ci --ignore-scripts to prevent the playwright-chromium postinstall (Chromium download) from hanging the build job. --ignore-scripts is independent of playwright's env-var naming, which has changed across releases, so it keeps working across future playwright upgrades. The build only runs tsc && vite build, which needs no install scripts (fsevents is darwin-only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
bpmn-visualizationfrom 0.44.0 to 0.48.0 inbpmn-rendering-miwg-test-suite, and adapt the surrounding code and CI.Changes
async/awaitfor clearer, linear control flow. Thefetchand theresponse.okcheck are split so only thefetchis wrapped intry/catch, which avoids a "throw of exception caught locally" warning while preserving the original error behavior.mainand on PRs, path-filtered to the subproject so unrelated changes don't trigger it.bonitasoft/*actions are external here since the repo lives under theprocess-analyticsorg, so they are pinned too.Verification
npm run build(tsc && vite build) passes in the subproject.