Repository navigation
Apply the oss-init conventions and keep Pages permissions off PR builds - #4
Merged
Merged
Conversation
The quality gate was a set of npm scripts that CI and the guides each listed on their own. `just ci` runs the build, the link check and a nixfmt check, and CI runs the same recipe. The flake lists its systems with nixpkgs.lib.genAttrs instead of flake-utils and is formatted with nixfmt. The dev shell names Node 24, since the scripts rely on Node's TypeScript type stripping, and provides just and nixfmt. The repository ignores its own .envrc, .direnv, result and worktrees instead of relying on a global ignore, and .gitattributes keeps checkouts LF on every OS. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
A CLAUDE.md anywhere in the tree makes Claude Code ignore AGENTS.md, and other agents read only AGENTS.md, so the guide lived where only one tool looked. Its content moves to a root AGENTS.md with the layer table, the quality gate (`just ci`), the layout, and the commit convention in use. The architecture rule no longer calls the repository "documents". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
Pull request builds ran with the Pages write and OIDC permissions and queued behind deploys in the single "pages" group. The gate is now its own job: it loads the dev shell and runs `just ci`, and a pull request cancels its superseded runs. Only the deploy job gets pages and id-token write, and it keeps the non-cancelling "pages" group. The workflow reads the repository by default, the checkout no longer keeps credentials, and the actions are on their latest majors. upload-pages-artifact v4 stopped including dotfiles, so the build's .vite directory is included explicitly to keep the deployed site the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
The manifest was still named @probitas/docs, a scope the project does not publish under, and without "private" a mistaken `npm publish` would try to release the site. It is now named after the repository and private. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just ciruns the nixfmt check,npm ci, the build and the link check; CI runs the same recipe. The flake drops flake-utils, names Node 24 (the scripts rely on type stripping) and adds just and nixfmt..gitignoreand.gitattributesfrom the template..claude/CLAUDE.md→ rootAGENTS.md; the architecture rule no longer calls the repository "documents". No ADR/spec directories here, sincedocs/is site content.cijob (nix-develop +just ci, PR runs cancel); only thedeployjob getspages/id-tokenwrite and keeps the non-cancellingpagesgroup. Actions on their latest majors; upload-pages-artifact v5 includes hidden files explicitly so the deployed site stays the same (v4 stopped including dotfiles such as.vite/).package.jsonis named after the repository and marked private.Why
Brings the site in line with the oss-init conventions used across the org, and stops pull request builds from running with Pages write permissions.
Test Plan
nix develop -c just ci(build, 62 link checks, nixfmt)nix flake check --no-build,actionlint🤖 Generated with Claude Code
https://claude.ai/code/session_01N3xvJ1TaozjYSE6eoyo9mq