The engine-version check ignores manifest changes npm never publishes - #209
Conversation
pnpm bump-version rewrites the engine's @repo/* devDependencies on every release bump, and devDependencies never ship in the tarball — so the check failed the rc.5 release PR for a change that leaves the published engine byte-identical. A change to the engine's manifest now counts only when something outside devDependencies differs. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reached
Next review available in: 57 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
2 participants
The check from #200 failed the rc.5 release PR (#207):
pnpm bump-versionrewrites the engine's@repo/*devDependencies on every release bump, and devDependencies never ship in the published tarball, so the shipped engine is byte-identical while the check saw "packages/cli-engine changed". A change to the engine's manifest now counts only when something outsidedevDependenciesdiffers. Four new tests pin the comparison.Unblocks #207.
🤖 Generated with Claude Code