Skip to content

The engine-version check diffs against the base branch's current tip #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmadden-electric merged 1 commit into from
Aug 18, 2026
Merged

The engine-version check diffs against the base branch's current tip #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,8 @@ jobs:

- name: The engine version must be new if the engine changed
env:
BASE_SHA: ${{ github.event.pull_request.base.sha }}
run: node scripts/check-engine-version.mjs "$BASE_SHA"
# The base branch by name: the event's base.sha is recorded when
# the pull request is created and goes stale as the base moves,
# which blamed other merges' engine changes on unrelated PRs.
BASE_REF: ${{ github.event.pull_request.base.ref }}
run: node scripts/check-engine-version.mjs "origin/$BASE_REF"
4 changes: 2 additions & 2 deletions scripts/check-engine-version.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
// `npx prisma@next` crashed on import. The registry is immutable, so a
// changed engine must claim a new version (`pnpm bump-cli-engine-version`).
//
// Usage: node scripts/check-engine-version.mjs <base-sha>
// Usage: node scripts/check-engine-version.mjs <base-ref>

import { execFile } from "node:child_process";
import { readFileSync } from "node:fs";
Expand Down Expand Up @@ -52,7 +52,7 @@ export function engineBumpVerdict({
async function main() {
const baseSha = process.argv[2];
if (!baseSha) {
console.error("Usage: node scripts/check-engine-version.mjs <base-sha>");
console.error("Usage: node scripts/check-engine-version.mjs <base-ref>");
process.exit(1);
}

Expand Down
Loading