The credential manager says what it decides instead of calling it a pin - #201
Conversation
The word is banned; the method moves the active-workspace pin after a mutation and discards storage built for the previous credential. A mechanical rename of a private method — no behaviour change. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe credential manager replaces 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
The concept is which credential this process acts as, decided at the first activeCredential() read. The type is now ActingAs, the field #actingAs, the resolver #resolveActingAs, and the mutation-time change #actAs — no reader has to learn what a pin was. Test descriptions move to the same words. No behaviour change; 978 tests pass. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
The operator's ask, twice over: first the banned word
#repin, then the whole "pin" vocabulary — nobody knows what a pin is. The concept is which credential this process acts as, decided once at the firstactiveCredential()read. The private surface now says that: typeActingAs, field#actingAs, resolver#resolveActingAs, and#actAsfor the mutation-time change that also discards storage built for the previous credential. Test descriptions use the same words. No behaviour change; all 978 CLI tests pass.🤖 Generated with Claude Code