Skip to content

Move Avatar borders inside the image - #8811

Draft
mattobee wants to merge 5 commits into
mainfrom
mattobee-avatar-inner-border
Draft

mattobee wants to merge 5 commits into
mainfrom
mattobee-avatar-inner-border

Conversation

@mattobee

Copy link
Copy Markdown
Contributor

Resolves github/primer#7417

Moves the Avatar border inside the image so it looks crisper against light and dark backgrounds. AvatarStack keeps its existing cutouts, and the decorative edge doesn't replace the keyboard focus ring.

Changelog

New

Changed

  • Standalone avatars draw their border inside the image.

Removed

Rollout strategy

  • No changes needed in github/github-ui

Testing & Reviewing

Check round and square avatars in light and dark themes. The edge should sit on the image, with no change to the gaps between stacked avatars.

@changeset-bot

changeset-bot Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e1487bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8811 November 20, 2026 13:45 Inactive
@primer-integration

primer-integration Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Waiting  Changes   Waiting
Failed  CI   Failed
Passed  VRT   Passed
Passed  Projects   Passed

CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures.

Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance.

@mattobee mattobee added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 20, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8811 November 20, 2026 13:56 Inactive
@github-actions github-actions Bot added the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Nov 20, 2026
@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 20, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8811 November 20, 2026 14:14 Inactive

This branch was successfully deployed

2 active deployments
storybook-preview-8811 — e1487bf2 Deployed Nov 20, 2026 by github-actions[bot]
github-pages — e1487bf2 Deployed Nov 20, 2026 by mattobee via deploy-preview #34476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant