Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nested-details-toggle.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': patch
---

Details: Keep the outer disclosure state unchanged when a nested disclosure is toggled.
21 changes: 21 additions & 0 deletions packages/react/src/Details/__tests__/Details.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,27 @@ describe('Details', () => {
await expect.element(page.getByTestId('summary')).toHaveTextContent('Open')
})

it('does not synchronize the outer open state with a nested toggle', async () => {
const Component = () => {
const {getDetailsProps} = useDetails({defaultOpen: true})
return (
<Details {...getDetailsProps()} data-testid="outer-details">
<Details.Summary>Outer summary</Details.Summary>
<details open data-testid="inner-details">
<summary>Inner summary</summary>
</details>
</Details>
)
}

render(<Component />)

await userEvent.click(page.getByText('Inner summary', {exact: true}))

await expect.element(page.getByTestId('inner-details')).not.toHaveAttribute('open')
await expect.element(page.getByTestId('outer-details')).toHaveAttribute('open')
})

describe('Details.Summary', () => {
it('should support a custom `className` on the container element', async () => {
render(<Details.Summary className="custom-class">test summary</Details.Summary>)
Expand Down
8 changes: 5 additions & 3 deletions packages/react/src/hooks/useDetails.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,12 @@ function useDetails({ref, closeOnOutsideClick, defaultOpen, onClickOutside}: Use
}, [open, closeOnOutsideClick, onClickOutsideInternal])

const handleToggle = (e: React.SyntheticEvent<HTMLElement, Event>) => {
if (!e.defaultPrevented) {
const eventTarget = e.target as HTMLDetailsElement
setOpen(eventTarget.open)
if (e.target !== e.currentTarget || e.defaultPrevented) {
return
}

const eventTarget = e.currentTarget as HTMLDetailsElement
setOpen(eventTarget.open)
}

const getDetailsProps = () => {
Expand Down