Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 85b44c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey @vivanvv! 👋 Could you take a look at the CI failure here? |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the Breadcrumbs RTL indentation fix.
No open issues 🎉
What changed in this PR
This PR fixes extra indentation in right-to-left Breadcrumbs layouts in @primer/react, while preserving left-to-right alignment.
Changes:
- Replaces
padding-leftwithpadding-inline-startto reset list indentation in both directions. - Adds tests checking first-crumb alignment in LTR and RTL layouts.
- Includes a patch changeset for the fix.
| File | Description |
|---|---|
packages/react/src/Breadcrumbs/Breadcrumbs.module.css |
Uses a direction-aware padding reset. |
packages/react/src/Breadcrumbs/__tests__/Breadcrumbs.test.tsx |
Adds LTR and RTL alignment regression tests. |
.changeset/fix-breadcrumbs-rtl-padding.md |
Records the Breadcrumbs fix for a patch release. |
Review effort: Max
|
Thanks for flagging this, Taylor! I investigated the failure: it’s TreeView’s “supports multiple typed characters” test, which also failed on All 53 Breadcrumbs tests passed in the PR’s React 19 CI run. I also ran the Breadcrumbs and TreeView tests locally on React 18 and 19, and both passed. This appears to be an intermittent test failure unrelated to the breadcrumb change. Would you be able to rerun the failed check? Thanks for taking a look! |
|
Integration test results from github/github-ui PR:
All checks passed! |
Breadcrumbs have an extra 40px of padding on the right in RTL layouts because
the list only resets
padding-left. This switches topadding-inline-startso the reset works in both directions.
Changelog
New
Tests for LTR and RTL alignment.
Changed
Fix the extra indentation in RTL breadcrumbs.
Removed
None.
Rollout strategy
Testing & Reviewing
All tests pass. The new RTL test fails without the fix.
Before:

After:
