Skip to content

Fix breadcrumb indentation in RTL layouts - #8707

Open
vivanvv wants to merge 3 commits into
primer:mainfrom
vivanvv:fix/breadcrumbs-rtl-padding
Open

vivanvv wants to merge 3 commits into
primer:mainfrom
vivanvv:fix/breadcrumbs-rtl-padding

Conversation

@vivanvv

@vivanvv vivanvv commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Breadcrumbs have an extra 40px of padding on the right in RTL layouts because
the list only resets padding-left. This switches to padding-inline-start
so the reset works in both directions.

Changelog

New

Tests for LTR and RTL alignment.

Changed

Fix the extra indentation in RTL breadcrumbs.

Removed

None.

Rollout strategy

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

Testing & Reviewing

All tests pass. The new RTL test fails without the fix.

Before:
RTL breadcrumbs with a 40px gap at the right edge

After:
RTL breadcrumbs aligned with the right edge

@vivanvv
vivanvv requested a review from a team as a code owner November 7, 2026 13:17
@changeset-bot

changeset-bot Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 85b44c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tay1orjones

Copy link
Copy Markdown
Contributor

Hey @vivanvv! 👋 Could you take a look at the CI failure here?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Breadcrumbs RTL indentation fix.

No open issues 🎉

What changed in this PR

This PR fixes extra indentation in right-to-left Breadcrumbs layouts in @primer/react, while preserving left-to-right alignment.

Changes:

  • Replaces padding-left with padding-inline-start to reset list indentation in both directions.
  • Adds tests checking first-crumb alignment in LTR and RTL layouts.
  • Includes a patch changeset for the fix.
File Description
packages/​react/​src/​Breadcrumbs/​Breadcrumbs.module.css Uses a direction-aware padding reset.
packages/​react/​src/​Breadcrumbs/​__tests__/​Breadcrumbs.test.tsx Adds LTR and RTL alignment regression tests.
.changeset/​fix-breadcrumbs-rtl-padding.md Records the Breadcrumbs fix for a patch release.

Review effort: Max

@vivanvv

vivanvv commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for flagging this, Taylor! I investigated the failure: it’s TreeView’s “supports multiple typed characters” test, which also failed on main.

All 53 Breadcrumbs tests passed in the PR’s React 19 CI run. I also ran the Breadcrumbs and TreeView tests locally on React 18 and 19, and both passed. This appears to be an intermittent test failure unrelated to the breadcrumb change.

Would you be able to rerun the failed check? Thanks for taking a look!

@vivanvv vivanvv mentioned this pull request Nov 10, 2026
1 of 5 tasks
@primer primer deleted a comment from primer-integration Bot Nov 19, 2026
@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  Changes   Passed
Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@tay1orjones tay1orjones added the integration-tests: skipped manually Changes in this PR do not require an integration test label Nov 19, 2026
@primer
primer Bot disabled auto-merge November 19, 2026 21:26
@primer
primer Bot enabled auto-merge November 19, 2026 21:26

This branch was successfully deployed

1 active deployment
github-pages — 85b44c20 Deployed Nov 19, 2026 by tay1orjones via deploy-preview #30772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants