Conversation
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
|
jonrohan
left a comment
There was a problem hiding this comment.
Looks good, shaved off about a minute, but probably not a lot of slow plugins involved like dotcom
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflows used for VRT and AAT Storybook builds to pass Storybook’s --test flag through Turborepo, aiming to speed up these builds while keeping the same set of stories.
Changes:
- Pass
--testtoturbo run build:storybookin the VRT workflow. - Pass
--testtoturbo run build:storybookin the VRT reports workflow. - Pass
--testtoturbo run build:storybookin the AAT reports workflow.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/vrt.yml | Adds --test passthrough to the Storybook build step used by the VRT snapshot-update path. |
| .github/workflows/vrt-reports.yml | Adds --test passthrough to the Storybook build step used by the VRT report runner. |
| .github/workflows/aat-reports.yml | Adds --test passthrough to the Storybook build step used by the AAT report runner. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Low
| - name: Build storybook | ||
| run: npx turbo run build:storybook | ||
| run: npx turbo run build:storybook -- --test |
| - name: Build storybook | ||
| run: npx turbo run build:storybook | ||
| run: npx turbo run build:storybook -- --test |
| - name: Build storybook | ||
| run: npx turbo run build:storybook | ||
| run: npx turbo run build:storybook -- --test |
|
@copilot apply review feedback |
Co-authored-by: joshblack <3901764+joshblack@users.noreply.github.com>
Head branch was pushed to by a user without write access
Pass Storybook’s
--testoption through Turborepo for VRT, snapshot-update, and AAT builds. Local builds were 15% faster while retaining all 1,169 stories.Changelog
New
Changed
--test.Removed
Rollout strategy
Testing & Reviewing
--test