Repository navigation
Conversation
…`SelectPanel` and `FilteredActionList`
|
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the composable SelectPanel integration while adopting graduated merged refs. Stabilize the virtualized example scroll-container ref to prevent ref-detach update loops. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use top-layer popovers for anchored panels while retaining native modality for modal, bottom-sheet, and fullscreen variants. Preserve invoker reconciliation and background-control focus, and harden transparent backdrops against application cascade layers. Keep non-default positioning strategies on the compatibility host. Legacy Dialog nesting remains a known follow-up. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Integration test results from github/github-ui PR: |
Warning
Very much a WIP. This PR explores a composable SelectPanel API, not a finalized proposal or implementation.
Roughly 80% of the added lines are tests and Storybook stories. The component implementation and styling account for only about around 3.2k added lines.
What if SelectPanel exposed its building blocks instead of requiring a new prop or escape hatch for each variation?
This experiment lets consumers compose their own layout while reusing Primer’s selection, keyboard navigation, and focus management:
Rootcoordinates state and behavior; the parts define the UI. Consumers can add search, groups, header actions, messages, and footers, or leave them out. Filtering remains consumer-owned, and searchable compositions default to active-descendant focus with roving focus available.Changelog
New
<dialog>and Invoker support.Changed
Removed
Rollout strategy
The configured adapter and native experiments are default-off:
primer_react_select_panel_composable_adapterprimer_react_select_panel_native_dialogprimer_react_select_panel_native_invokersTesting & Reviewing
Feedback is especially welcome on the API boundaries, accessibility, and whether the parts offer useful flexibility without making common cases cumbersome.