Skip to content

Set the markdown <hr> thickness to 1px ($border-width) #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dapirian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set the markdown <hr> thickness to 1px ($border-width) #3157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/markdown-hr-thickness.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": patch
---

Set the markdown `<hr>` (thematic break) thickness to 1px using `$border-width`, down from 4px, so it matches Primer's line weight and the ~1px used by other markdown renderers.
2 changes: 1 addition & 1 deletion src/markdown/markdown-body.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
}

hr {
height: $em-spacer-3;
height: $border-width;
padding: 0;
margin: var(--base-size-24) 0;
// stylelint-disable-next-line primer/colors
Expand Down
Loading