Repository navigation
Conversation
Renamed to perpendicular-flap-3d (not to be confused with the perpendicular-flap-3d case in the openradioss-cases repository). Source: https://github.com/elisa-santoro/openradioss-cases/tree/0f3058514b5d91701ee1d9732809aa0d2216bfd1/pulsating-flow-over-flexible-flap-3d-case1 co-authored-by: elisa-santoro <e.santoro2001@gmail.com>
MakisH
marked this pull request as ready for review
November 11, 2026 19:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates pulsating-flow-over-flexible-flap-3d-case1 to the tutorials and adds it to the system tests.
The reasons I selected this case are:
perpendicular-flapcase that would be simpler would be confusing, as it would need a differentprecice-config.xml(the current one assumes 2D, the one for OpenRadioss would need 3D, unless the adapter is modified to support 2D simulations).In the process, I have made some changes:
perpendicular-flap-3d, instead of the original namepulsating-flow-over-flexible-flap-3dfor two reasons: (a) to better relate with the currentperpendicular-flaptutorial, (b) to keep the name shorter. There is anotherperpendicular-flap-3dcase in the original repository, but that is pseudo-2d, since the flap takes the complete third dimension and it only has a few cells per it.setup-openradioss.shscript undertools/. I removed theshopt -s expand_aliases.toVTKat the end of therun.sh, to make theanim_to_vtktool optional, as it is an additional dependency.export:vtutags. They are not used, and the system tests add an exporter anyway.README.mdin the style of a tutorial, and I added images from my local run (with 4 MPI ranks).Note that this case is quite heavy. With 4 MPI ranks for the fluid, the case took 4h30m on my laptop to complete (max time: 30s). This PR sets the default to 8 MPI ranks and gives related hints in the documentation.
Also note that, while OpenRadioss as we know it does not exist anymore, I kept the name for historical continuity, and since the case was originally developed for OpenRadioss. The system tests use OpenCourant (the main open-source/community fork at the moment), and the README will point to it as well.
The system tests fail at the comparison step, even if I pin the OpenCourant version. This confuses me, but it is already good to know that the tutorial works. Note that the documentation recommends running OpenFOAM in parallel to save time, but the tests run OpenFOAM in serial (no particular reason; I just only realized now; I might change this when I look deeper into the numerical differences).
Checklist
For new tutorials or tutorial cases:
README.mdmetadata.yamltests/tests.yaml_config.yaml@carme-hp could you please have an overview look and try to run the case?
@elisa-santoro FYI. Please let me know if you spot anything wrong.
I would like to get this merged soon, to have it in the upcoming tutorials release (and @elisa-santoro in the next distribution release). It's already been a while that this project has been completed.