Skip to content

Remove note to closed issue in heatexchanger tutorial - #917

Open
fsimonis wants to merge 1 commit into
developfrom
fsimonis-patch-1
Open

Remove note to closed issue in heatexchanger tutorial#917
fsimonis wants to merge 1 commit into
developfrom
fsimonis-patch-1

Conversation

@fsimonis

@fsimonis fsimonis commented Sep 9, 2026

Copy link
Copy Markdown
Member

Removes this note:

image

As the issue was closed due to the simplified heat exchanger tutorial.

#6

Checklist

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • If I changed requirements.txt files, I regenerated sibling requirements-reference.txt files with python3 tools/releasing/update-requirements-reference.py (pass a path to update only that directory, or --all to refresh everything).

@fsimonis
fsimonis requested a review from MakisH September 9, 2026 12:44
@MakisH

MakisH commented Sep 9, 2026

Copy link
Copy Markdown
Member

I think there has been a misunderstanding here. The note is still relevant for the heat-exchanger tutorial. I mainly closed the issue because it was inactive since the beginning. If anything, we could just remove the "You can help us improve this" linking to the issue.

@fsimonis

Copy link
Copy Markdown
Member Author

I think if you link to an issue that is "closed as complete", people (including me) will think this is done.

I suggest making it explicit what you are looking for. The issue is the large mesh, right?
Maybe something along the lines of

If you can contribute an alternative mesh smaller than X, please contact us or open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants