Skip to content

Wrong order of writing data #27

Description

@MakisH

These should be reverted:

self.precice.write_data(self.nodesMeshName, self.writeDataNames[0], self.preciceNodeIndices, writeHCoeff)
self.precice.write_data(self.nodesMeshName, self.writeDataNames[1], self.preciceNodeIndices, writeTemp)

But we have a deeper issue here: Since we use a list (self.writeDataNames[0]) and not a dictionary, it is easy to mess up the order. These are set here:

def setDataNames(self, names):
for writeDataName in names["write-data"]:
if writeDataName.find("Heat-Transfer-Coefficient-Solid") >= 0:
self.writeDataNames.append(writeDataName)
elif writeDataName.find("Sink-Temperature-Solid") >= 0:
self.writeDataNames.append(writeDataName)
for readDataName in names["read-data"]:
if readDataName.find("Heat-Transfer-Coefficient-Fluid") >= 0:
self.readData[readDataName] = None
elif readDataName.find("Sink-Temperature-Fluid") >= 0:
self.readData[readDataName] = None

Reported by a user in the forum: https://precice.discourse.group/t/unexpectedly-high-interface-temperature-in-openfoam-code-aster-heat-transfer-coupling/2377/4

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions