Skip to content

Core: Add host config for ActivityInfrastructure - #4706

Open
CTMBNara wants to merge 2 commits into
masterfrom
add-host-config-for-activity-infra
Open

CTMBNara wants to merge 2 commits into
masterfrom
add-host-config-for-activity-infra

Conversation

@CTMBNara

Copy link
Copy Markdown
Collaborator

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@Net-burst Net-burst changed the title Add host config for ActivityInfrastructure Core: Add host config for ActivityInfrastructure Nov 12, 2026
@aleksUIX

Copy link
Copy Markdown

Setting activity-infrastructure to valid JSON currently prevents startup. @Value("activity-infrastructure") injects that literal, so mapper.decodeValue fails with Unrecognized token 'activity' instead of reading the host configuration. Can this use @Value("${activity-infrastructure}")? Please add a Spring context test with the property enabled; the creator tests construct hostConfig directly and do not exercise this binding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants