Handle GVL deletions#4519
Open
Lightwood13 wants to merge 7 commits into
Open
Conversation
CTMBNara
previously approved these changes
Jun 3, 2026
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
CTMBNara
requested changes
Jul 3, 2026
| return fileSystem.readDirBlocking(cacheDir).stream() | ||
| .filter(filepath -> filepath.endsWith(JSON_SUFFIX)) | ||
| .collect(Collectors.toMap(VendorListFileStore::parseCachedFileVersion, | ||
| filename -> fileSystem.readFileBlocking(filename).toString())); |
Collaborator
There was a problem hiding this comment.
.collect(
Collectors.toMap(VendorListFileStore::parseCachedFileVersion,
filename -> fileSystem.readFileBlocking(filename).toString()));
Comment on lines
+44
to
+47
| return vendors.entrySet().stream() | ||
| .filter(entry -> !VendorListUtil.vendorIsDeletedAt(entry.getValue(), now)) | ||
| .filter(entry -> !liveVendorListService.isDeleted(entry.getKey())) | ||
| .collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue)); |
Collaborator
There was a problem hiding this comment.
what about to wrap with MapView instead of reconstructing the whole map? It may contain a big amount of entries
| private static Integer parseCachedFileVersion(String filepath) { | ||
| final String filename = new File(filepath).getName(); | ||
| final String filenameWithoutExtension = StringUtils.removeEnd(filename, JSON_SUFFIX); | ||
| return Integer.valueOf(filenameWithoutExtension); |
| public void createCacheFromDiskShouldFailIfNoWritePermissionsForCacheDir() { | ||
| // given | ||
| final String cacheDir = tempDir.toString(); | ||
| tempDir.toFile().setWritable(false, false); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes?
Periodically fetch latest GVL and handle deleted vendors.