Add Vert.x UriTemplate#4444
Open
CTMBNara wants to merge 18 commits into
Open
Conversation
CTMBNara
force-pushed
the
add-vertx-uri-template
branch
2 times, most recently
from
025ac24 to
8b7b3ed
Compare
CTMBNara
force-pushed
the
add-vertx-uri-template
branch
from
8b7b3ed to
0227b04
Compare
# Conflicts: # src/test/resources/org/prebid/server/it/test-application.properties
CTMBNara
force-pushed
the
add-vertx-uri-template
branch
from
a907d2c to
6f23995
Compare
This reverts commit d0c723c.
# Conflicts: # extra/modules/optable-targeting/src/test/java/org/prebid/server/hooks/modules/optable/targeting/v1/BaseOptableTest.java # extra/pom.xml # src/main/java/org/prebid/server/spring/config/bidder/SmartadserverConfiguration.java # src/main/java/org/prebid/server/vertx/httpclient/CircuitBreakerSecuredHttpClient.java # src/test/java/org/prebid/server/bidder/gumgum/GumgumBidderTest.java # src/test/java/org/prebid/server/spring/config/bidder/util/UsersyncerCreatorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes:
BIDDER.yamlconfiguration file must be converted as follows:{{MACRO}}->{MACRO}org.prebid.server.util.UriBIDDERBidder.javafile must be converted as follows to work with new API:{{MACRO}}->MACROHttpApplicationSettingsRfc3986:request-id=id2&request-id=id1&imp-id=id2&imp-id=id1->request-id=id2%2Cid1&imp-id=id2%2Cid1Config properties:
hooks.modules.optable-targeting.api-endpoint:{{TENANT}}->{TENANT},{{ORIGIN}}->{ORIGIN}analytics.liveintent.analytics-endpoint: path and query parameters will now be appended to the endpoint instead of replacing the existing ones.Bidder configuration specific changes:
Adkernel:%s->{Zone}Adot:{{PUBLISHER_PATH}}->{/PUBLISHER_PATH*}AudienceNetwork:{partner},{app},{auction}macros addedBrave:{{.PublisherID}}->{PublisherID}Eplanning:{ClientId},{DfpClientId},{RequestTarget},{Sec}macros addedLunamedia:{Pid}macro addedMobfoxpb:__route__->{route},__method__->{method},__key__->{key}Smartrtb{PubId}macro addedRubicon:rubicon.default-tk-x-intproperty addedTappx:{path}macro addedYeahmobi:{{.Host}}->gw-{ZoneId}-bid.yeahtargeter.comYieldlab:{AdSlotId}macro addedSmartadserver:smartadserver.secondary-endpoint->smartadserver.pg-endpoint/api/bidsuffix should be added tosmartadserver.endpoint/ortbsuffix should be added tosmartadserver.pg-endpointImprovedigital:{{PathPrefix}}pbs->{PathPrefix}/pbsGamoshi:gamoshi.endpoint:endpoint->endpoint/r/{SupplyPartnerId}/bidr?bidder=prebid-serverKueezRtb:{ConnectionId}macro addedMgid:{AccountId}macro addedUcfunnel:ucfunnel.endpoint:endpoint->endpoint/{PartnerId}/requestVidazoo:{ConnectionId}macro addedOmnidex:{ConnectionId}macro addedTagoras:{ConnectionId}macro addedBeachfront:exchange_idquery param moved to bidder code. Remove it from.yamlconfig