Repository navigation
feat(prompt-input): add PromptInput with token highlighting - #3
Closed
pratikbuilds wants to merge 1 commit into
Closed
pratikbuilds wants to merge 1 commit into
pratikbuilds wants to merge 1 commit into
Conversation
PromptInput is a fully controlled form. PromptInputTextarea draws @mention and /command tokens on an aria-hidden mirror beneath transparent native text, grows through field-sizing with a measured fallback, and never submits during IME composition. usePromptInput drives PromptInputSuggestions from the keyboard, and PromptInputSubmit turns Send into Stop while a reply is running.
Owner
Author
|
Moved upstream: corbitsdev#115 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PromptInput is a fully controlled form. PromptInputTextarea draws @mention and /command tokens on an aria-hidden mirror beneath transparent native text, grows through field-sizing with a measured fallback, and never submits during IME composition. usePromptInput drives PromptInputSuggestions from the keyboard, and PromptInputSubmit turns Send into Stop while a reply is running.
Stacked on #2: review only this commit. Part of corbitsdev#94.
Notes for review
statuslives onPromptInput(root), notPromptInputSubmit: Enter must see the status so it never sends mid-reply;PromptInputSubmittakes onlyonStop.canSubmiton PromptInput (defaultvalue.trim() !== "") lets a host send attachments with no text, e.g.canSubmit={value.trim() !== "" || files.length > 0}; Enter and Send both honour it; disabled, busy status and IME composition still block.Verification
bun run typecheckandbun run linton its own (the stack is checked commit by commit).bun run check,bun run build,bun run dep-guard,bun run contrast-testandbun run test:e2e(Playwright specs and the Storybook axe sweep in light and dark) pass.Closes corbitsdev#102