Repository navigation
release: v2.30.1 — Hide Images decorative fixes & Google Translate default adapter - #203
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0c3b3358f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cache.set( | ||
| cacheKey, | ||
| translateOfflineText(textKey, request.targetLanguage), | ||
| ); |
There was a problem hiding this comment.
Add a usable offline fallback for the new target languages
When the network request fails for ar, hi, pt, ru, ko, it, or nl, the offline helper has no lexicon for that language and returns the input unchanged; this branch caches that text as a successful translation, so the widget still reports the page translated. Add offline support for these targets or signal that fallback is unavailable instead of silently returning untranslated content.
AGENTS.md reference: AGENTS.md:L10-L10
Useful? React with 👍 / 👎.
| record.target.matches( | ||
| "img, picture, video, [data-video], .video-placeholder, iframe", | ||
| ) |
There was a problem hiding this comment.
Reapply hiding when video markers change
If hideVideos is active and a page script later adds data-video or .video-placeholder to an existing element, this observer queues it, but applyIncremental skips elements already processed in the initial pass. The marker therefore never causes the element to be hidden; reapply the effect to changed elements or trigger a refresh.
AGENTS.md reference: AGENTS.md:L12-L12
Useful? React with 👍 / 👎.
Releases \�ccessibility-plugin-react@2.30.1\ following PR #202 and resolves issue #201 (sub-issue of #8).
Highlights
ole='presentation'|'none', \�ria-hidden='true', including parent <picture>) before non-empty \�lt/\�ria-label/\ itle\ checks.
Verification
pm run format:check\ &
pm run validate\ (\ sc --noEmit, \ sc --noEmit -p tsconfig.tests.json, ESLint, 51 unit/integration files / 521 tests, tsup + CSS build): passed
pm run pack:check\ &
pm run test:consumers\ (ESM+SSR, CJS, React 18 Vite, React 19 Tailwind, Next.js 16): passed
Release Publishing
Merging this PR into \main\ updates \package.json\ to \2.30.1, triggering .github/workflows/publish.yml\ via npm OIDC.