Repository navigation
Conversation
Since 7.1.0, throwError made the reporter throw as soon as any message was logged, including messages that are neither warnings nor errors (e.g. a filter letting dependency messages through). Fixes #77
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 7.1.0 (#75),
throwErrormakes the reporter throw as soon as any message is logged, including messages that are neither warnings nor errors. For example, afilter: () => truelettingdependencymessages through breaks the build even without any warning.This restores the behavior documented in the README: with
throwError, the reporter throws when at least one warning is logged. Errors still always make it throw, as introduced in 7.1.0.lib/reporter.js.Fixes #77