Repository navigation
Recognize case-insensitive import and layer at-rule names - #615
Merged
RyanZim merged 4 commits intoOct 13, 2026
Merged
Conversation
romainmenke
reviewed
Oct 9, 2026
romainmenke
left a comment
romainmenke
left a comment
Collaborator
There was a problem hiding this comment.
Can you reduce the diff a bit?
Only lowercase layer and import and try to avoid whitespace changes.
Thank you
RyanZim
approved these changes
Oct 12, 2026
RyanZim
left a comment
RyanZim
left a comment
Collaborator
There was a problem hiding this comment.
Couple of consistency nits in the tests, otherwise, looks good.
Co-authored-by: Ryan Zimmerman <opensrc@ryanzim.com>
RyanZim
reviewed
Oct 12, 2026
Collaborator
|
Published in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSS at-rule names are ASCII case-insensitive, but uppercase or mixed-case @import is left unresolved. A following lowercase @import is also incorrectly warned about as out of order. An uppercase @layer statement is similarly not recognized when checking the import prelude.
Compare the relevant at-rule names without changing their original serialization. Added regressions cover uppercase imports, mixed-case consecutive imports, and an uppercase layer statement.
Validation: all three new regressions fail on the original code and pass after the fix. ESLint passes. 91 tests pass excluding the pre-existing "should contain a correct sourcemap" failure, which was separately reproduced with the original parse-statements.js; the full suite has that same single failure on this Windows setup.
Reference: https://www.w3.org/TR/css-syntax-3/#at-rules
Maintainer review addressed in a98dbcc: only import and layer names are lowercased; charset remains case-sensitive. Restored surrounding layout to reduce the diff. Added a regression confirming uppercase CHARSET remains an ordinary at-rule and correctly blocks a following import; it failed before this adjustment and passes afterwards.