DEBUG: cancel test traceback capture (do not merge) - #280
Closed
cpsievert wants to merge 3 commits into
Closed
Conversation
Demonstrates that shinychat main alone breaks the Shiny sidebar E2E tests (test_03_sidebar_apps.py title tests) due to a timing regression introduced in posit-dev/shinychat#280 interacting with the in-process app servers used by the Playwright fixtures.
…_fixture The threaded in-process uvicorn fixtures shared Shiny's process-global, loop-bound reactive lock across apps. When two apps on different event loops contended for the lock, the session's message handler crashed with 'bound to a different event loop' and the chat message was dropped, hanging the sidebar title tests. shinychat main (posit-dev/shinychat#280) widened that race window enough to fail CI reliably. create_app_fixture runs each app in its own subprocess (as Shiny's own test suite does), giving each app its own loop and lock. This matches how the Streamlit fixtures already work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary diagnostic PR to capture tracebacks for cancel-test failures seen on #279.