Repository navigation
fix: hide pages until fully composed to eliminate flash of unstyled content - #428
Merged
Merged
Conversation
📚 Preview this PR's docs locallyFetch the just-built site and open it in your browser: # this exact build
great-docs preview --run 40018743924
# or always the latest build for this PR
great-docs preview --pr 428Auth & tips
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When navigating between pages, I noticed a few FOUT-like things (the navbar would disappear and reappear, the sidebar would briefly show unstyled links without headers or icons, and the "On This Page" header would pop in last). This happened because
theme-init.jsruns frominclude-in-header, which Quarto places after<body>, not inside the<head>.This PR fixes this with an inline
<style>in themetadata.htmlPandoc partial now hides the page before any body content renders. The previous approach usedvisibility: hidden, but child elements withvisibility: visible !important(sidebar sections, TOC) could leak through, so the fix also addsopacity: 0on<body>which children cannot override. A doublerequestAnimationFramein the reveal ensures after-body scripts (sidebar, dark-mode toggle, tags, etc.) have painted before the page becomes visible. A<noscript>fallback keeps pages visible when JavaScript is disabled.Note that this fix doesn't address keeping the navbar on the screen while loading a new page. That's something that could be done in a separate PR (more involved of a fix).