Python semantic layer: injection resolution and the public API - #256
Draft
jat255 wants to merge 2 commits into
Draft
Python semantic layer: injection resolution and the public API#256jat255 wants to merge 2 commits into
jat255 wants to merge 2 commits into
Conversation
jat255
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of four stacked PRs building the Python semantic layer (M3). Based on #249. Completes the milestone.
resolve_injections(measures, injectables)applies the three rules for an injected measure argument. An argument named after a data source receives that source's connection, even when the argument has a default. One matching no source keeps its default. One matching no source and having no default is an error naming the measure, the arguments, and the sources that are available.It takes a plain
Mapping[str, Any], not a data-source type, and nothing in this milestone imports the data layer. That boundary is deliberate rather than a shortcut around M2 not being finished:resolve_injections()inpkg-r/R/measures.Ralso takes a plain named list, whilemeasure_injectables(), the part that knows what a data source is, lives inpkg-r/R/commons.Rwith the agent. M5 supplies the mapping when it builds the agent, which is where the error surfaces to a user.Nothing calls
resolve_injections()yet for that reason. Its caller is the agent constructor, which M5 adds.Also exports the public API:
Injected,Measure,SemanticLayer,measure, andsemantic_layer.measure_schema_text()andresolve_injections()stay private, matching the R package's export discipline, since they are seams the agent layer imports rather than API a measure author uses. The test fixture files move to the public import path in the same commit, which is what checks the surface is usable the way a measure author will use it.Verified on both supported interpreters: 187 tests pass on 3.11 and 3.13.