Improve caching for effects resolution - #1380
Open
lionel- wants to merge 5 commits into
Open
Conversation
lionel-
force-pushed
the
oak-nse/21-effect-cache
branch
from
July 31, 2026 07:08
5961947 to
3f068cf
Compare
lionel-
force-pushed
the
oak-nse/21-effect-cache
branch
4 times, most recently
from
July 31, 2026 12:28
2a43818 to
a6062ec
Compare
No longer needed given the eager linear pass
lionel-
force-pushed
the
oak-nse/21-effect-cache
branch
from
July 31, 2026 14:23
a6062ec to
fe3de07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #1338
Effect resolution now memoizes per
(name, attached)pair to avoid rewalking the cross-file layer chain on every call.The static effect registry (
base,magrittr,rlang,S7,shiny,testthat,withr) is now indexed by name in aLazyLock<FxHashMap>built once, to avoid a linear scan on everylookup()/annotates()call.ImportLayer::Fromnow holds thePackageitself instead of a freshly-rebuiltHashMapof itsimportFromtable. The map is now cached by its own query (Package::imported_from()).Positron Release Notes
New Features
Bug Fixes