Reorganise scanner and walk code - #1375
Open
lionel- wants to merge 6 commits into
Open
Conversation
lionel-
force-pushed
the
oak-nse/16-walk-split
branch
from
July 30, 2026 15:24
92e03cd to
2936a61
Compare
lionel-
force-pushed
the
oak-nse/16-walk-split
branch
from
July 31, 2026 07:08
2936a61 to
877d1f6
Compare
lionel-
force-pushed
the
oak-nse/16-walk-split
branch
from
July 31, 2026 12:28
877d1f6 to
7ef5f0a
Compare
lionel-
force-pushed
the
oak-nse/16-walk-split
branch
from
July 31, 2026 14:23
7ef5f0a to
78e3cb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #1338
Splits
builder.rsintoscan.rsandwalk.rs. The state is correspondingly split inScanStateandWalkState.builder_nse.rsis noweffects.rsand no longer contains code specific to the scan and walk. It's now about effect resolution.Positron Release Notes
New Features
Bug Fixes