Extract arguments field and generalise NSE with ArgumentEffect - #1345
Open
lionel- wants to merge 1 commit into
Open
Extract arguments field and generalise NSE with ArgumentEffect#1345lionel- wants to merge 1 commit into
arguments field and generalise NSE with ArgumentEffect#1345lionel- wants to merge 1 commit into
Conversation
lionel-
force-pushed
the
oak-nse/7-effects-refactor
branch
2 times, most recently
from
July 17, 2026 11:26
f152897 to
f6eddb4
Compare
lionel-
force-pushed
the
oak-nse/7-effects-refactor
branch
from
July 17, 2026 13:55
f6eddb4 to
bd44ef0
Compare
lionel-
force-pushed
the
oak-nse/7-effects-refactor
branch
2 times, most recently
from
July 22, 2026 15:25
1780438 to
fd06b4a
Compare
lionel-
force-pushed
the
oak-nse/7-effects-refactor
branch
2 times, most recently
from
July 30, 2026 14:38
79c4207 to
caeeefd
Compare
lionel-
force-pushed
the
oak-nse/7-effects-refactor
branch
2 times, most recently
from
July 31, 2026 07:08
614abe2 to
a3f304b
Compare
lionel-
force-pushed
the
oak-nse/7-effects-refactor
branch
from
July 31, 2026 12:28
a3f304b to
8e46284
Compare
lionel-
force-pushed
the
oak-nse/7-effects-refactor
branch
from
July 31, 2026 14:23
8e46284 to
9007f91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress towards #1338
Branched from #1344
Refactor, no behavior change. Generalizes the per-argument NSE annotations into general per-argument effects. This allows declaring an argument as Quote or Eval in future PRs.