Repository navigation
Fix/composer recreate dispose - #398
Merged
Merged
Conversation
…composer Old composer's dispose() killed EffectGroup/N8AO/user passes and their effects still in use by the new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #397.
When the composer is recreated, the old composer's
dispose()also disposed passes the new composer reuses: theEffectGrouppass, N8AO and user-provided passes. ForEffectGroupthis disposed the grouped effects and dropped the pass'schangelistener, so the group stopped reacting to effect changes after e.g. a camera switch.The old composer now detaches every pass it didn't create before disposing itself.