Skip to content

FIX / Remove deprecated /public prefix from plugin URLs #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mary-Clb wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −6
Open

FIX / Remove deprecated /public prefix from plugin URLs #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993b210
rm deprecated public prefix from urls
Mary-Clb Sep 4, 2026
9be68a9
update CHANGELOG.md
Mary-Clb Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
### Fixed

- Enforce item / pref rights and sanitize inputs in tree loading
- Remove deprecated `/public` prefix from generated plugin URLs


## [1.20.2] - 2026-06-24
Expand Down
8 changes: 4 additions & 4 deletions inc/config.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,15 +161,15 @@ public function seeTreeview()
echo "<meta http-equiv='Pragma' content='no-cache'>\n";
echo "<meta http-equiv='Cache-Control' content='no-cache'>\n";
echo "<link rel='shortcut icon' type='images/x-icon' href='" .
$CFG_GLPI['root_doc'] . "/public/pics/favicon.ico' >\n";
$CFG_GLPI['root_doc'] . "/pics/favicon.ico' >\n";

// Must be always the top window
echo '<script type="text/javascript">';
echo 'if (top != self)';
echo 'top.location = self.location;';
echo '</script></head>';
echo "<frameset cols='250,*'>";
echo "<frame src='" . $CFG_GLPI['root_doc'] . "/plugins/treeview/public/left.php' name='left' scrolling='yes'>";
echo "<frame src='" . $CFG_GLPI['root_doc'] . "/plugins/treeview/left.php' name='left' scrolling='yes'>";
echo "<frame src='" . $CFG_GLPI['root_doc'] . "/front/central.php' name='right'>";
echo '<noframes>';
echo '<body>';
Expand Down Expand Up @@ -204,8 +204,8 @@ public function buildTreeview()
$treeview_url = $CFG_GLPI['root_doc'] . "/plugins/treeview";

//necessary files needed for the tree to work.
echo sprintf("<link rel='stylesheet' type='text/css' href='%s/public/css/dtree.css' type='text/css'>", $treeview_url);
echo sprintf("<script type='text/javascript' src='%s/public/lib/dtree/dtree.js'></script>", $treeview_url);
echo sprintf("<link rel='stylesheet' type='text/css' href='%s/css/dtree.css' type='text/css'>", $treeview_url);
echo sprintf("<script type='text/javascript' src='%s/lib/dtree/dtree.js'></script>", $treeview_url);

echo "<div class='dtree'>";
echo "<script type='text/javascript'>";
Expand Down
2 changes: 1 addition & 1 deletion inc/preference.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public static function getMenuContent()

$menu = [];
$menu['title'] = __s('Tree view', 'treeview');
$menu['page'] = '/' . $CFG_GLPI['root_doc'] . 'plugins/treeview/public/index.php';
$menu['page'] = '/' . $CFG_GLPI['root_doc'] . 'plugins/treeview/index.php';
$menu['icon'] = 'ti ti-sitemap';

return $menu;
Expand Down
2 changes: 1 addition & 1 deletion setup.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function plugin_init_treeview()
&& isset($_SESSION['glpi_plugin_treeview_preference'])
&& $_SESSION['glpi_plugin_treeview_preference'] == 1
) {
Html::redirect($CFG_GLPI['root_doc'] . '/plugins/treeview/public/index.php');
Html::redirect($CFG_GLPI['root_doc'] . '/plugins/treeview/index.php');
}

if (
Expand Down