Repository navigation
Manage dashboard access rights per Group and per User - #144
Open
MichaelRodriguesOficial wants to merge 8 commits into
Open
MichaelRodriguesOficial wants to merge 8 commits into
MichaelRodriguesOficial wants to merge 8 commits into
Conversation
stonebuzz
requested changes
Jul 17, 2026
Rom1-B
requested changes
Jul 22, 2026
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Stanislas <skita@teclib.com>
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
MichaelRodriguesOficial
marked this pull request as draft
September 1, 2026 21:38
MichaelRodriguesOficial
marked this pull request as ready for review
September 2, 2026 16:14
MichaelRodriguesOficial
marked this pull request as draft
September 2, 2026 16:24
MichaelRodriguesOficial
marked this pull request as ready for review
September 2, 2026 18:24
Rom1-B
requested changes
Sep 14, 2026
Rom1-B
left a comment
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
Please correct the CI issues before requesting another review.
- Fix PHP syntax error introduced by the docblock suggestion in itemright.class.php - Render the rights matrix with a Twig template (no more echo) - READ on the group/user is enough to see the tab, UPDATE is required to save - Check rights on the targeted group/user itself, not only the global right - Rename dashboard_uuid column to dashboard_id - Add int type hint and docblock on canCurrentUserViewDashboard() - Remove rights when a group or user is purged - Rebase on GLPI 12 / 1.5.0 and add CHANGELOG entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0115rGXdmY7mffoJzXeFPGhw
Author
|
Thanks for the reviews, and sorry for the noise — the CI failures came from a suggestion I applied This is now fixed and rebased on 1.5.0 / GLPI 12:
Lint, PHP-CS-Fixer, PHPStan, Psalm, Rector, TwigCS and licence headers pass locally against GLPI 12, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to better manage access to the dashboards.
Checklist before requesting a review
Description
Currently, dashboard access can only be granted per Profile. This PR adds the ability to also grant (or deny) access per Group and per User, using the same rights mechanism (
Profile::dropdownRight) already used for profiles.PluginMetabaseItemrightclass, mirroringPluginMetabaseProfileright, storing rights keyed byitemtype(GrouporUser) +items_id+dashboard_uuid.group/userUPDATE rights, to manage dashboard access for that group/user.I did not add automated tests since the plugin doesn't currently have a test suite in place.
Screenshots: