Skip to content

Playwright::chromium([...]) silently ignores unknown options (channel, proxy, ...) #194

Open

Description

@tacman

Version: 1.5.0.

Playwright::launch() honors only headless, slowMo, args and context. Anything else is silently dropped. Playwright::chromium(['headless' => true, 'channel' => 'nonesuch']) launches the bundled Chromium without complaint. I used channel and proxy this way and believed they worked; I only noticed from a screenshot-size difference and then from the user-agent. Browser context options such as ignoreHTTPSErrors also have to be nested under context.

channel and proxy are supported through PlaywrightConfigBuilder + PlaywrightFactory, which also rejects an unknown channel properly: Unsupported chromium channel "nonesuch". (Related: #191, withExecutablePath().)

Suggestion: either map the documented launch options, or throw InvalidArgumentException for keys the helper doesn't handle. A short pointer from the README's launch-options section to PlaywrightConfigBuilder for channel/proxy would also help.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions