Experimental engaged session switch - #6610
Open
ukutaht wants to merge 2 commits into
Open
Conversation
ukutaht
force-pushed
the
engaged-session-switch
branch
from
August 19, 2026 20:20
b973bdc to
6aac6a9
Compare
|
aerosol
approved these changes
Aug 20, 2026
aerosol
left a comment
Member
There was a problem hiding this comment.
Interesting idea, let's see how it behaves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
An experiment to see how it would look like to add a 'engaged sessions only' filter to deal with bot traffic. An engaged session is defined as a session with at least one
engagementevent.This is intentionally the smallest way to test this in production. It is meant to be easily revertable. If the experiment is a success in that the filter:
Then the plan is to revert this commit and think about how to build this properly. Currently it ignores many considerations including realtime data, imported data, and historical data before
engagementevents were even added.Changes
For superadmins only, adds a UI switch that always applies a
[:has_done, [:is, "event:name", ["engagement"]]filter to all API requests. Does not apply to the current visitors number and when enabled, imported data is inaccessible due to backend rules.Tests
Changelog
Documentation
Dark mode