Pool replicate samples instead of refusing the run - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR replaces the duplicate-sample refusal with replicate pooling and exposes pooling details through the manifest, CLI report, and run-statistics UI. Important touched terms:
PooledGrouptype records its condition, gate, sample IDs, and fraction disagreement.pooledGroups.(variantKey, gate)for replicated gates.Confidence Score: 4/5
The fraction-validation ordering should be fixed before merging because replicated inputs can conceal invalid per-sample values and produce corrected scores.
Replicate fractions are reduced to a non-null mean before the existing presence and range checks run, so an invalid original value can become an accepted pooled value.
Files Needing Attention: software/src/pooling.py, software/src/pipeline.py, software/src/validate.py
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Selected-gate read rows] --> B[Group replicate samples] B --> C[Sum reads by condition, gate, and variant] B --> D[Average replicate sort fractions] C --> E[Pooled reads table] D --> E E --> F[Validate pooled fractions] F --> G[Score retained conditions] G --> H[Score and distribution files] B --> I[pooledGroups report] H --> J[Run manifest] I --> J J --> K[CLI report and Run Statistics UI]Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "Pool replicate samples instead of refusi..." | Re-trigger Greptile
Context used (5)